XSS Mitigation #49
Open
XSS Mitigation #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When modifing the organization info a user can detail a description, in this input any special character can be introduced even javascripts tags. I've added a sanitization in order to prevent the browser interprets these tags.
nutteen
pushed a commit
to GroupLeasePCL/sentrifugo
that referenced
this pull request
Jul 9, 2018
…lidays-error Employee timesheet holidays error
nutteen
pushed a commit
to GroupLeasePCL/sentrifugo
that referenced
this pull request
Jul 9, 2018
…lidays-error Employee timesheet holidays error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When modifying the organization info a user can detail a description, in this input any special character can be introduced even javascripts tags. This could lead to an XSS vulnerability. We've added a sanitization in order to prevent the browser interprets these tags.
We also suggest checking this kind of vulnerability in the rest of the code, the best solution would be to use a template engine such as Twig.